fix: websocket proxy endpoints (/proxy/:port and /ab... in index.ts#7872
Closed
orbisai0security wants to merge 2 commits into
Closed
fix: websocket proxy endpoints (/proxy/:port and /ab... in index.ts#7872orbisai0security wants to merge 2 commits into
orbisai0security wants to merge 2 commits into
Conversation
Automated security fix generated by OrbisAI Security
WebSocket proxy endpoints (/proxy/:port and /absproxy/:port) are accessible without authentication, allowing unauthenticated users to proxy traffic to internal services
Member
|
We have been here before: #7766 |
Author
|
Apologies for the duplicate PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix critical severity security issue in
src/node/routes/index.ts.Vulnerability
V-001src/node/routes/index.ts:116Description: WebSocket proxy endpoints (/proxy/:port and /absproxy/:port) are accessible without authentication, allowing unauthenticated users to proxy traffic to internal services.
Evidence
Exploitation scenario: An unauthenticated attacker can connect to ws://target-server/proxy/3000/ to proxy to internal service on port 3000, or ws://target-server/absproxy/5432/ to access PostgreSQL.
Scanner confirmation: multi_agent_ai rule
V-001flagged this pattern.Production code: This file is in the production codebase, not test-only code.
Threat Model Context
This route handler appears to be publicly accessible. This is a web service - vulnerabilities in request handlers are directly exploitable by remote attackers.
Changes
src/node/routes/index.tsVerification
Security Invariant
Regression test
This test guards against regressions — it's useful independent of the code change above.
Automated security fix by OrbisAI Security